Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

fixed ibft tests #1876

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fixed ibft tests #1876

merged 1 commit into from
Sep 6, 2023

Conversation

rachit77
Copy link
Contributor

@rachit77 rachit77 commented Sep 6, 2023

Description

This PR fix the failing IBFT tests in nightly build

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@rachit77 rachit77 added the bug fix Functionality that fixes a bug label Sep 6, 2023
@rachit77 rachit77 self-assigned this Sep 6, 2023
Stefan-Ethernal
Stefan-Ethernal approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just manually trigger this action on your fork (https://github.com/0xPolygon/polygon-edge/actions/workflows/e2e.yaml) before we merge it?

@rachit77 rachit77 changed the base branch from develop to rachit77/ibft-fix September 6, 2023 08:52
@rachit77 rachit77 merged commit ee4e408 into 0xPolygon:rachit77/ibft-fix Sep 6, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@vcastellm vcastellm Awaiting requested review from vcastellm

@goran-ethernal goran-ethernal Awaiting requested review from goran-ethernal

Assignees

@rachit77 rachit77

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rachit77 @Stefan-Ethernal