Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Use function signature when multiple functions are defined #1854

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Use function signature when multiple functions are defined #1854

merged 1 commit into from
Aug 29, 2023

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented Aug 28, 2023 •
edited
Loading

Description

ChildERC20PredicateAccessList has 2 “initialize“ functions in the JSON ABI.

The binding generator must use the overwritten function instead of the parent one.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@begmaroman begmaroman self-assigned this Aug 28, 2023
@begmaroman begmaroman added the bug fix Functionality that fixes a bug label Aug 28, 2023
@begmaroman begmaroman marked this pull request as ready for review August 28, 2023 11:56
vcastellm
vcastellm approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begmaroman begmaroman merged commit 4369155 into develop Aug 29, 2023
@begmaroman begmaroman deleted the feature/EVM-807 branch August 29, 2023 11:54
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@vcastellm vcastellm vcastellm approved these changes

Assignees

@begmaroman begmaroman

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@begmaroman @vcastellm @igorcrevar @Stefan-Ethernal