Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: An option to exclude softlinks (at least for linux) #544

Open
bassklampfe opened this issue Nov 2, 2024 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@bassklampfe
Copy link

Environment

  • OS: Linux (but may apply to others too)

Describe desired feature

Add an option to exclude softlinks from file traversal

What issue does it solve?

If you use WINE, the wine folder typically has a folder name "dosdevices" and in this folder there is a link
z: -> /
so if you include any folder which has a wine environment inside, this will include the complete filesystem of the host. Even worse, this will create a recousion and vdf will parse the file tree endlessly or until memory is used up.

@bassklampfe bassklampfe added the enhancement New feature or request label Nov 2, 2024
@0x90d
Copy link
Owner

0x90d commented Dec 27, 2024

Why do you use this app in Wine? There is also a Linux and a MacOS build.

@bassklampfe
Copy link
Author

I don't use videoduplicatefinder in Wine, I use it native on Linux. But I use other Windows programs with Wine on my system, and when videoduplicatefinder descent into such a wine folder, then the issue arises.

@bassklampfe
Copy link
Author

@0x90d : Wine was only the example, where I became aware of the issue.

To show up, this is not related to Wine, but only to symlinks.
Some steps to reproduce without wine (assuming you don't have Wine on your system, I verified in a fresh VmWare-Machine with linuxmint-22)

  • cd ~/Videos
  • ln -s / Z:
  • copy some videos into the Videos folder (I tried with ~100 Files with ~16 GB together)
  • start VDF.GUI
  • add "Videos" folder to Search Directory
  • start scan

VDF shows "Please Wait Enumerating files...", stays inoperable and runs until memory+swap is used up, then gets killed by the linux kernel

Simply ignoring symlinks during enumeration would solve the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants