Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bonus files ending with _bonus aren't searched #29

Open
MyNameIsTrez opened this issue Nov 25, 2021 · 2 comments
Open

Bonus files ending with _bonus aren't searched #29

MyNameIsTrez opened this issue Nov 25, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@MyNameIsTrez
Copy link

According to @ska42 this should've been fixed in #19, but this doesn't seem to be the case.

Screen Shot 2021-11-25 at 4 46 56 PM

What I've been having to do so far is renaming all 9 bonus files to remove the _bonus suffix, and to also remove _bonus suffix from the hardcoded paths of the files in the Makefile (not allowed to use wildcards yet).

The deepthought file shows it errors when it searches for ft_lstnew.c, while it should fall back to ft_lstnew_bonus.c:

= Bonus_functions ==============================================================

= ft_lstnew_bonus.c ============================================================
$> norminette ft_lstnew_bonus.c | grep -E '(Error|Warning)'
$> clang -Wextra -Wall -Werror -g3 -fsanitize=address ft_lstnew.c main.c libft.a -o user_exe

clang: error: no such file or directory: '/Users/sbos/Evals/intra-uuid-479083c1-2738-490c-ae1f-f5457fb58ea4-3883824-1/libft-war-machine/dirlibft//ft_lstnew.c'

Here's my libft for reproducing my issue: libft-sbos.zip

@0x050f
Copy link
Owner

0x050f commented Nov 25, 2021

Ups, I might have fucked up when modifying for path with spaces, will look at it 👌

@Trolent
Copy link

Trolent commented Sep 26, 2023

It still doesn't work for me. Was the issue fixed ?

@0x050f 0x050f added the bug Something isn't working label Mar 22, 2024
E10YDEV pushed a commit to E10YDEV/libft-war-machine that referenced this issue Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants